[Trisquel-devel] [PATCH 99/99] Modified the privacy policy webpage in the "About" dialog from "https://www.mozilla.org/en-US/legal/privacy/" to "https://www.mozilla.org/en-US/legal/privacy/firefox.html"

[Andrew Lindley]

From: isleofmax <isleofmax at gmail.com>
Subject: [Trisquel-devel] [PATCH 99/99] Modified the privacy policy 
webpage in the "About" dialog from 
"https://www.mozilla.org/en-US/legal/privacy/" to 
"https://www.mozilla.org/en-US/legal/privacy/firefox.html"
Date: Sat, 14 Dec 2013 15:17:37 +0100

/patch snipped/

Hi Massimo

Firstly congratulations on getting further than I and using git 
send-email.  I have some QA comments on your patch.  Sorry for the 
delay, December was a RL mess for me.

1) You need to increment the

      VERSION=N

    variable in the helper file and include that in your patch.  The 
N ends up as 6.0trisquelN at the end of the full package / release 
name, so it is needed.

2) According to man git-format-patch the scissors format of your 
discussion text is incorrect.  See 3rd paragraph + 1 example into the 
DISCUSSION section of that man page.

3) In your discussion text please explain why you're going for an 
en-US target page when Abrowser has translations.

4) There's no mention of the Issue number it is for in the comments.  
IIRC Rubén has said on IRC he would like a link in the helper to each 
issue.  Please put a full http:// link to the issue concerned next to 
your code change in the patch.  I'd also suggest a link to the 
revised patch email on the trisquel-devel mailing list archive pages 
be put in the Issue itself.

The last two are 'Pro QA' YMMV things.

5) Pro QA would say that in your helper comment changhe should be 
spelt change.  Steve Oualline's O'Reilly C and C++ books have it that 
misspellings and abbreviations are known to cause random problems for 
non-native English speakers.

6) Again Pro QA would ask you to fix wherever the trailing blanks on 
lines are that cause the warning message when you add the patch to a 
repo using git am.


Leny